search

NikhilM98 / sugarizer-school-portal-server

Sugarizer School Portal Server manages Kubernetes cluster to provide on-demand Sugarizer Server instances.
https://sugarizer.org
Apache License 2.0
3 stars 6 forks source link

Localize mail content #37

Closed ricknjacky closed 3 years ago

ricknjacky commented 3 years ago

issue ref:- #15

llaske commented 3 years ago

Ooch. I'm not a big fan of hard coded localization. Is it possible to include it in a localization file instead?

ricknjacky commented 3 years ago

Ooch. I'm not a big fan of hard coded localization. Is it possible to include it in a localization file instead?

Agreed. After, discussing the previously proposed solution with @NikhilM98, He suggested that I create a new JS file with a function that generates translated emails and then eventually call this function in api/controller/users.js file.

This way, the mail generation process will be more robust and rightly so. I have integrated this feedback in my recent commits, kindly review it and share feedback/suggestions if any.

ricknjacky commented 3 years ago

@llaske Now we use localization files. tested with both hindi and english.

Screenshot from 2021-06-22 14-08-05 Screenshot from 2021-06-22 13-22-08