NikhilNamal17 commented 5 years ago

Do you know any popular movie quotes? Add your quote to data.json inside the data/ folder and raise the PR. Language: Only English

{  
      "quote": "Your new Quote",
      "movie": "movie name",
      "type": "movie/anime/tv",
      "year": 2012
}

Note:

Please avoid the repetition of quotes. Add your quotes in between. Don't add at the bottom or at the top. Follow the template. Do not make any changes in other files. Add me(@NikhilNamal17 ) as reviewer. Thanks!

robflop commented 5 years ago

Hello, I have a question. Does "first-timers-only" (and its hovertext "Send your first PR") refer to one's first Hacktoberfest PR or how is this to be understood?

NikhilNamal17 commented 5 years ago

The label refers to their first open-source contribution. Basically this issue is targeted for beginners but there are no restrictions.

robflop commented 5 years ago

Okay, thank you. If multiple PRs can be accepted for this issue then I would like to submit one. If not I will leave it for someone that is a beginner.

jdim commented 5 years ago

Hi, can I help? It's funny))

NikhilNamal17 commented 5 years ago

@robflop Yes, you can send multiple PR.

DylPickle11 commented 5 years ago

Ok I will also do that! YAY!

bigton54 commented 5 years ago

I would like to add some!

k1dnyy commented 5 years ago

I would love to add a few!

MSurfer20 commented 5 years ago

Can I contribute?

rvk7895 commented 5 years ago

I would like to contribute to this.TIA

Harshwp commented 5 years ago

I would love to contribute

NikhilNamal17 commented 5 years ago

@MSurfer20 sure.

jaywantpatel commented 5 years ago

Can I contribute to this ?

NikhilNamal17 commented 5 years ago

@jaywantpatel sure.

davidlfox commented 5 years ago

How can I test this locally before submitting PR?

davidlfox commented 5 years ago

How can I test this locally before submitting PR?

from project directory

cd ..
mkdir popular-movie-quotes-test
cd popular-movie-quotes-test
npm install ../popular-movie-quotes
npm install requirejs
cp ../popular-movie-quotes/demo/demo.js .
node demo.js

Babadzhanov commented 5 years ago

added #77

ShivashMahespalsingh commented 5 years ago

Are Indian movie quotes also allowed?

NikhilNamal17 commented 5 years ago

Are Indian movie quotes also allowed?

@ShivashMahespalsingh currently only English movies.

davidlfox commented 5 years ago

Are Indian movie quotes also allowed?

@ShivashMahespalsingh currently only English movies.

You might consider adding expectations like this to either the issue or maybe even the readme

dominikS007 commented 5 years ago

Can I contribute ?

rajk1121 commented 5 years ago

I want to add a quote.

anshuldutt21 commented 5 years ago

Hi, I want to contribute

colis123 commented 5 years ago

Hello. Id like to add some

toledodavid commented 5 years ago

Hi, I would like to contribute

ShivashMahespalsingh commented 5 years ago

I see a that lot of the JSON objects in the data.json files have different formats. Most of them have the "type" property missing is this an issue? Or does the code expect this kind of input?

NikhilNamal17 commented 5 years ago

I see a that lot of the JSON objects in the data.json files have different formats. Most of them have the "type" property missing is this an issue? Or does the code expect this kind of input?

@ShivashMahespalsingh that objects with parameter missing are old data, in beginning we didn't asked for type and year, we updated the template but then it was too much data, adding manually was impossible.

NikhilNamal17 commented 5 years ago

Also, I cleared all duplicates quotes too. Now it's around 1k lines. It would be great if someone can review and add missing attributes,

ShivashMahespalsingh commented 5 years ago

Also, I cleared all duplicates quotes too. Now it's around 1k lines. It would be great if someone can review and add missing attributes,

I will review the objects and create a pull request after adding the missing attributes.

Somrajkarki commented 5 years ago

Hi, can i contribute?

piyushs2894 commented 5 years ago

Hi Nikhil, I have created a new PR for new quote. Can u please check it? https://github.com/NikhilNamal17/popular-movie-quotes/pull/139

anshgit101 commented 5 years ago

i am submitting pr with my contribution to the movie quotes please review

anshuldutt21 commented 5 years ago

Added movie quotes #164

prosaicpudding commented 5 years ago

What a fun way to build a dataset. I will add some as well.

darpanjbora commented 5 years ago

Also, I cleared all duplicates quotes too. Now it's around 1k lines. It would be great if someone can review and add missing attributes,

Hi @NikhilNamal17 I have created a new issue for the same. #210
I have added the missing attribute "type" to all the objects. Submitted PR #211 Kindly review and accept the PR. Also adding the script that I had used for reference.

const data = require("../data/data.json"); const fs = require('fs'); var new_data = data.map( datum => { var newField = Object.assign({}, datum); newField.type = "movie"; return newField; }) fs.writeFileSync('file.json', JSON.stringify(new_data));

prosaicpudding commented 5 years ago

I've noticed a few quotes that are misattributed. Would correcting that fall under this issue as well?

thoughtworks-tcaceres commented 5 years ago

I would like to contribute. :)

iepoch commented 5 years ago

I would like to work on this as well! :)

gurundoro commented 5 years ago

please review #234

Volence commented 5 years ago

Just did my first pull request ( #242 ) on github! I'm used to gitlab so please let me know if I did anything incorrectly. I tagged you in that but I'm not sure if that made you the reviewer. Thanks for this project!