NikhilPeri / resume

Career goal is to not have a resume...till then
2 stars 0 forks source link

OEC2018 #1

Open NikhilPeri opened 6 years ago

NikhilPeri commented 6 years ago

A Hacky chat solution for oec 2018

MooseV2 commented 6 years ago

First post

You can also edit other comments on github issues Dont do this, play nice

  • Nik
NikhilPeri commented 6 years ago

UPDATE 2018-01-26 20:58:26 My internet is shit trading will be delayed by 15 min

NikhilPeri commented 6 years ago

WE ARE LIVE! any issues now should be real

arilotter commented 6 years ago

buying stocks still throws a 500 for me

dfsisinni commented 6 years ago

image

NikhilPeri commented 6 years ago

^ looking into this, my internet is spotty so I will see if I can recreate it

NikhilPeri commented 6 years ago

Not a CORS problem, it was server side...fix just went out and 🎩 'd it we should be rolling

arilotter commented 6 years ago

@NikhilPeri Unrelated to selling, I'd like if you added CORS headers so I can call the API from the browser.

arilotter commented 6 years ago

The API is bugged: it does not show the actual value of remaining cash when you call /api/account, instead it always shows 10000000.

arilotter commented 6 years ago

Our account was reset, and all our holdings deleted. ????

zako160 commented 6 years ago

^ same

CSchank commented 6 years ago

Can we get an api for only current amount and historical as a separate thing?

dfsisinni commented 6 years ago

our holdings keep disappearing

NikhilPeri commented 6 years ago

THERE WAS A MAJOR BUG IN STORING TRANSACTIONS...mostly cause by me not storing them, lol I have reset all account holdings and cash. and fixed the bug

ColinNowers commented 6 years ago

@NikhilPeri are you ranking the performance on cash value right now?

NikhilPeri commented 6 years ago

No it is ranked by total_value = holding + cash value

z3t0 commented 6 years ago

There is a non conformance to the docs for one of the API call results. 'historical_prices' is actually returned as 'historical_price'.

kimwoo11 commented 6 years ago

whats going on with the standings lol

z3t0 commented 6 years ago

is the historical price at index 0 the most recent or oldest

AcharyaS97 commented 6 years ago

Im getting a 404 error trying to buy

NikhilPeri commented 6 years ago

deploying the following fixes:

The historical price is index 0 is oldest

SamTheOnionMan commented 6 years ago

It's down right now too, can't access the main page to see the graph or anything.

NikhilPeri commented 6 years ago

can everyone add time outs between price calls...I have 2 webservers and I dont want to add a third

Mogball commented 6 years ago

90 stocks * 14 teams, checking prices every minute. Please Add a third webserver

edit: hotel wifi is making this hard enough already -- just bought another 1gb of data ecksdee

NikhilPeri commented 6 years ago

you cost me so much money... added a 3rd the down time was because of this

also to be fair i am currently using the shittiest servers heroku offers

SamTheOnionMan commented 6 years ago

What were the deleted comments about 🤔

Mogball commented 6 years ago

Get uOttawa to reimburse ;^)

DanielCefaratti commented 6 years ago

Do historical prices always include the current tick?

NikhilPeri commented 6 years ago

unless there is a weird race condition it should

NikhilPeri commented 6 years ago

the home view was kinda fucked...I think i fixed it 🤷‍♂️

SamTheOnionMan commented 6 years ago

not investing everything I had into JOE - worst mistake of my life

CSchank commented 6 years ago

It would be nice if this hotel had good internet....

zako160 commented 6 years ago

is it me or is the market not updating

arilotter commented 6 years ago

it just updated, but it's definitely slow

NikhilPeri commented 6 years ago

Sorry I had to pause the simulation to scale up the sidekiq workers....but my wifi craped out so i couldnt restart it

done now! and added some more stocks TOTAL COUNT IS 160

DanielCefaratti commented 6 years ago

Do all stocks always fluctuate every tick? Or can they remain static?

SamTheOnionMan commented 6 years ago

they haven't changed in like 10 minutes

SamTheOnionMan commented 6 years ago

at least my portfolio hasnt

SamTheOnionMan commented 6 years ago

I need to talk to my accountant about that

Mogball commented 6 years ago

It takes me 5 minutes to query the price of all stocks, can you add an endpoint that allows us to simultaneously retrieve all stock prices? This reduces the load on both our ends

DanielCefaratti commented 6 years ago

Well I don’t know if that’s on purpose or because of the internet problems, I’d like confirmation

Mogball commented 6 years ago

I'm ticking on multiple threads and every 5-6 seconds it'll hang for 15 seconds then go back at it again

NikhilPeri commented 6 years ago

Maybe you should not query the whole dataset every-time and make some smart decisions

Mogball commented 6 years ago

This is "big data" problem, more data = more money

SamTheOnionMan commented 6 years ago

it takes like 10 seconds to query with this internet and we cant just watch like 3 stocks

NikhilPeri commented 6 years ago

right now I am runnning 28 requests per second and response time is about 2 sec per request I AM WORKING ON A PR TO THROTTLE PEOPLE MAKING LOTS OF REQUESTS this falls under the ddos rule so I suggest you re-think what data you "need" or prepare to see a slow down

arilotter commented 6 years ago

Stocks have different lengths of historical price arrays - for example, YIR has 135 elements and WHT has 142.

NikhilPeri commented 6 years ago

also no one said yo have to run this on you laptop....there were points for designing a system which can actually be deployed

☁️

Mogball commented 6 years ago

I brought an 8-core (x2 for hyperthreading) desktop

NikhilPeri commented 6 years ago

@arilotter stocks can be added an removed from the exchange depending on price, you code should be reseliant to this