search

NikiforovAll / keycloak-authorization-services-dotnet

Authentication and Authorization with Keycloak and ASP.NET Core 🔐
https://nikiforovall.github.io/keycloak-authorization-services-dotnet/
MIT License
480 stars 113 forks source link

feat: update kiota api to 25.0.2 #129

Closed Persistent13 closed 6 days ago

Persistent13 commented 3 months ago

This updates the Kiota package to the 25.0.2 release of Keycloak.

I think this is all good but please let me know if you need anything else from me!

Persistent13 commented 3 months ago

I'm going to investigate the src/Directory.Packages.props conflict.

Are the other conflicts of issue? I'd think not since they're generated but I'm not sure if that's due to something being generated incorrectly.

Persistent13 commented 3 months ago

I figured it out, I had an outdated main. I'll rebase and push the changes.

NikiforovAll commented 3 months ago

Can we somehow reduce the number of changes? I remember pinning the Kiota tool version that should be used for generations to avoid these massive changes. Could you please provide a version of the kiota tool that was used for the process of generation?

Persistent13 commented 3 months ago

Can we somehow reduce the number of changes? I remember pinning the Kiota tool version that should be used for generations to avoid these massive changes. Could you please provide a version of the kiota tool that was used for the process of generation?

It was 1.16.0 to build this and the prior version according to the lock file was 1.15.0.

I'll downgrade, rerun this, and push the changes.

Persistent13 commented 3 months ago

Follow up on this, my goal here was to bring in the organization APIs since those are new for 25 and I just assumed that 25.0.0 didn't have them for whatever reason but it turns out they're just plain missing from the openapi definition file at this moment. https://github.com/keycloak/keycloak/issues/30832

Once that's addressed, I'll update this PR. Until then I'll put it in a draft state but if that's undesirable for you, feel free to close it and I can always reopen it.

xXAvoraXx commented 3 months ago

It would be great if after creating a Role or Group, the ID of the created entity could be returned. @Persistent13

https://github.com/keycloak/keycloak/discussions/32027

Persistent13 commented 6 days ago

Closing in favor of #154