search

NikiforovAll / keycloak-authorization-services-dotnet

Authentication and Authorization with Keycloak and ASP.NET Core 🔐
https://nikiforovall.github.io/keycloak-authorization-services-dotnet/
MIT License
480 stars 113 forks source link

Update Kiota API to 26.0.5 #154

Open Persistent13 opened 6 days ago

Persistent13 commented 6 days ago

closes: #148

Persistent13 commented 6 days ago

I'm going to update the out-of-date action bits to the latest and see what, if anything, breaks.

Persistent13 commented 6 days ago

image

Nice!

@NikiforovAll Let me know if there's anything disagreeable in this PR and I'll do my best to correct.

NikiforovAll commented 6 days ago

@Persistent13 Could you please update the version of the Kitoa package manually?

NikiforovAll commented 6 days ago

Also, kiota CLI has been installed as dotnet-tool, could you please update id and try to regenerate to make sure we use the same version of Kiota CLI

NikiforovAll commented 6 days ago

Also, please make changes from https://github.com/NikiforovAll/keycloak-authorization-services-dotnet/pull/148 to this PR

NikiforovAll commented 6 days ago

First and foremost, thank you for the contribution

Persistent13 commented 5 days ago

@NikiforovAll I've updated the kiota versions and re-ran the generation command. I used 1.14.0 as that was newer, if you'd like me to use 1.13.1 explicitly, please let me know.

I updated the nuget package version to 26.0.5.

Please let me know if there's anything else.

NikiforovAll commented 5 days ago

Thank you for your contribution. Did you run dotnet tool restore in the root of the directory? I think we have kiota 1.15 installed as a local dotnet tool. Could you please update the version of the local dotnet tool and re-run the generation? 

dotnet tool install --local Microsoft.OpenApi.Kiota --version 1.20.0

Also, it would be great to test the generated SDK manually to make sure everything works. What do you think?

Persistent13 commented 5 days ago

Yes, I did run it with the cached version. Apologies!

I think the new push should have corrected this. I won't be able to test it my time tonight, but I should be able to tomorrow. I'll update with my findings then.

NikiforovAll commented 5 days ago

I appreciate your work!