fix: Remove early returns in claims transformation - Githubissues

NikiforovAll / keycloak-authorization-services-dotnet

Authentication and Authorization with Keycloak and ASP.NET Core 🔐

https://nikiforovall.github.io/keycloak-authorization-services-dotnet/

MIT License

480 stars 113 forks source link

fix: Remove early returns in claims transformation #99

Closed Alexr03 closed 6 months ago

Alexr03 commented 6 months ago

Issue: Current implementation will flow to an early return statement when all of the following requirements are met:

RolesClaimTransformationSource.All is set
The user does not have any roles in the requested resource
The user does have a realm role

Expected Result: The realm role will be applied to the principal.

Actual Result: The realm role is not applied to the principal.

Resolution:

Remove early returns and allow the method to flow to the end where it will return with the final principal.
Added tests to check for this case.

NikiforovAll commented 6 months ago

thank you for the fix