NikitaIvanovV / ctpv

Image previews for lf file manager
https://www.nikitaivanov.com/man1/ctpv
MIT License
264 stars 24 forks source link

Make buildable on alpine #27

Closed boscovn closed 1 year ago

boscovn commented 1 year ago

I couldn't build it on alpine linux, did some digging around and it turns out that since alpine uses musl as a standard library implementation, imports are handled differently, this won't affect functionality, it will just be compatible with alpine and potentially other musl-based distros

NikitaIvanovV commented 1 year ago

Have you tried make CC=musl-gcc?

NikitaIvanovV commented 1 year ago

Oh, never mind my previous message, I thought it was an issue and you asked how to build with musl.

NikitaIvanovV commented 1 year ago

What kind of error message did you get when you didn't include sys/types.h? Could you please post the message here?

boscovn commented 1 year ago

ssyze_t undefined

boscovn commented 1 year ago

I'm not on my computer now but it was a compilation error of that nature, will post the full message when I get there

NikitaIvanovV commented 1 year ago

Don't bother with sending the actual message, I think it's not a big deal to add another include if it makes ctpv possible to compile with musl. Thank you for the fix!

boscovn commented 1 year ago

No problem!