missing dependency in install instructions

[Joyje]

Hi! It seemed ridiculous to make a fork to make a pull request simply to just add a package name in README.md. The missing package in question is libssl. Without it, running make gives an error openssl/md5.h: No such file or directory. Since there is also a package named openssl that won't fix the dependency, it is worth mentioning libssl in the README file.

[NikitaIvanovV]

It depends on your system which packages you need to install to obtain libcrypto. What package manager/distribution do you use? If you it's a popular one, you can list all the required packages here and I can include them in the README.

[Joyje]

I use debian 12 so yeah, 😅 quite a popular distro.

I also noticed on multiple forums that a lot of people on ubuntu got this error message when trying to build various source code without libssl. So yeah, this dependency package is relevant for a lot of people. 👍

The 2 dependencies you already listed with the addition of libssl should be all I think. I'm not sure if openssl is required as well since I already had it installed, but I can't test that at the moment.

How would you mean this is related to libcrypto? Those are 2 separate packages. Installing libcrypto won't fix this particular error since that isn't the missing dependency in question.

[NikitaIvanovV]

How would you mean this is related to libcrypto? Those are 2 separate packages. Installing libcrypto won't fix this particular error since that isn't the missing dependency in question.

I think there is a confusion here: I'm talking about libcrypto library, not a package. libssl is a package that installs libcrypto library.

Another library ctpv depends on is libmagic. libmagic1 package seems to install the library for your system. Could you please check if this package is installed?

Thank you!

[Joyje]

Aha! I think I get you.

I installed libmagic1 and libcrypto++8 before running make, got the error and assumed I needed openssl. Installing openssl didn't fix the dependency however, so after a sufficient amount of online searches I discovered that this error needs libssl to be resolved.

Am I correct to understand that libcrypto++8 was never necessary in the first place then? I will try to run make after removing libcrypto and openssl packages to see if it works without errors.

[NikitaIvanovV]

Am I correct to understand that libcrypto++8 was never necessary in the first place then?

I cannot say for sure but I think so.

I will try to run make after removing libcrypto and openssl packages to see if it works without errors.

If it's simple to do, please do!

[Joyje]

Removing libcrypto++8 didn't create any issues running make, so at least we can confirm that I never needed to install that in the first place.

Now with openssl it's a bit more complicated to test, since it seems to have replaced dependencies for a bunch of other packages that I don't want to break. I'm not sure if openssl would be necessary for running make, but I would assume not.

The correct dependencies would most likely only be libmagic1 and libssl-dev for Debian based systems.

[IIlllllII]

For Void Linux users: libcrypto3, openssl-devel, libmagic.

[ipstone]

I am having similar issue on centOS 7 (sorry for the ancient system, but it's what I am using now):

• install file-dev will fix the need for libmagic header file
• I am having this error now:

  ctpv make
  make -C embed
  make[1]: Entering directory '/home/peix/Downloads/ctpv/embed'
  make[1]: 'embed' is up to date.
  make[1]: Leaving directory '/home/peix/Downloads/ctpv/embed'
  cc -o src/ctpv.o src/ctpv.c -c -O2 -MMD -Wall -Wextra -Wno-unused-parameter -I/usr/include -I/usr/include
  src/ctpv.c:9:10: fatal error: openssl/md5.h: No such file or directory
  9 | #include <openssl/md5.h>
    |          ^~~~~~~~~~~~~~~
  compilation terminated.
  make: *** [Makefile:56: src/ctpv.o] Error 1

any suggestion would be appreciated!