search

NiklasEi / bevy_asset_loader

Bevy plugin helping with asset loading and organization
Apache License 2.0
482 stars 53 forks source link

Partial upgrade to Bevy 0.9-dev. #87

Closed rparrett closed 1 year ago

rparrett commented 1 year ago

Dropping this here in case it's useful. Please feel free to close or do as you like with any of the code.

Draft because this is incomplete. Missing features that use iyes_* crates.

I'm also not totally confident in the strategy I used with the AssetCollection and Resource traits.

NiklasEi commented 1 year ago

Thanks a lot! I will most likely not merge it, but use parts of it when I get to updating :slightly_smiling_face:

HugoPeters1024 commented 1 year ago

works for me in a basic setting :), thanks

NiklasEi commented 1 year ago

I will now close this in favour of #92. Looking at the two PRs there are two differences I found:

  1. I chose not to implement Resource for all AssetCollections, because in the future I am expecting some configuration options on the trait (like we already have for Component) and I like to have them explicitly marked as resources in user code
  2. Resource is Sync + Send + 'static, so I could clean up the trait bounds a bit