search

NiklasEi / bevy_game_template

Template for a Bevy game including CI/CD for web, Windows, Linux, macOS, iOS and Android
https://niklasei.github.io/bevy_game_template/
Creative Commons Zero v1.0 Universal
844 stars 89 forks source link

Replace unmaintained actions-rs/toolchain action in CI workflows #58

Closed striezel closed 1 year ago

striezel commented 1 year ago

Basically all of the actions-rs/* actions are unmaintained. See https://github.com/actions-rs/toolchain/issues/216 for more information. Due to their age they generate several warnings in CI runs, for example in https://github.com/NiklasEi/bevy_game_template/actions/runs/4772937853:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

To get rid of those warnings the occurrences of actions-rs/toolchain are replaced by dtolnay/rust-toolchain.

janhohenheim commented 1 year ago

Just a little PSA: the toolchain you use now ignores rust toolchain files. It doesn't matter in this case, but something to keep in mind :)

NiklasEi commented 1 year ago

Just a little PSA: the toolchain you use now ignores rust toolchain files. It doesn't matter in this case, but something to keep in mind :)

This just reminded me of your ping in janhohenheim/foxtrot#249, which I had entirely forgotten to answer on :see_no_evil: Thanks for the heads-up! I haven't used toolchain files before, but it's good to know, should they ever come up.

janhohenheim commented 1 year ago

@NiklasEi hehe yeah, I thought you might recognize this PR from somewhere 😉