search

NiklasEi / gamebox

Minecraft plugin with a vast selection of inventory games
http://gamebox.nikl.me
GNU General Public License v3.0
17 stars 12 forks source link

Mavenize #6

Closed RoboMWM closed 7 years ago

RoboMWM commented 7 years ago

LaxWasHere was gonna PR the InventoryHolder to your repo, but it isn't mavenized, and it seems like a lot of work to gather all the dependencies.

Maven is a way to manage dependencies, and also allows others to easily import your project to PR.

NiklasEi commented 7 years ago

LaxWasHere was gonna PR the InventoryHolder to your repo, but it isn't mavenized, and it seems like a lot of work to gather all the dependencies.

Yes, that's exactly what I noticed when I wanted to start using maven, so I kept on delaying that problem. At the moment it was always easier to simply add the dependency for the local project.

I'll get started with that in some study-free hours. Would be really nice if I finally managed to get rid of the manual dependeny hell. Maybe you could assist me when I run into problems.

I'll keep you posted in this issue.

LaxWasHere commented 7 years ago

We're in hell if you need any help.

NiklasEi commented 7 years ago

making slow progress https://github.com/NiklasEi/GameBox/tree/mavenize

NiklasEi commented 7 years ago

Could one of you varify that the current mavenize branch can be imported and build as is?

I fixed all remaining problems and can now compile a functional .jar with mvn clean package.

RoboMWM commented 7 years ago

Oooh modules, something I haven't had to resort to doing yet.

Will test shortly..

RoboMWM commented 7 years ago

Yup, seems to compile just fine here.