Closed CloudeLecaw closed 1 year ago
any news about? :3
I haven't looked at 1.17, no. Thinking about this now, I should really try to remove my dependency on nms code, so users need to wait less when there are new mc versions.
Is there any news for support 1.17 and 1.18 ?
No :( we waited for it since 1.17 is out
It still looks like I cannot get rid of my NMS usage. This means I need to keep updating the plugin for new versions.
I moved on from Minecraft/Spigot in the last years, so my focus is on other projects which leads to such issues being open so long. I am very sorry about that!
I'll try and make another push to 1.17 (which should also cover most changes to 1.18)
Wil it also work for 1.19?
No this code is only up to 1.16. I got a fork to 1.17 but not to 1.18 or higher. This dependency is not 1.18 or 1.19 compatible https://github.com/NiklasEi/nmsutilities
bump...for 1.19 support
I am open to review and merge PRs adding support for new versions, but it's unlikely that I will work much on it myself.
I got a fork to 1.17 but not to 1.18 or higher.
@resi23 would you like to open a PR for 1.17 support then? I would be very interested in how you set up the maven config and the updated nms-utilities. That's what I got stuck on last time I tried to update, since there were some bigger changes in 1.17.
@NiklasEi I checked I didn't do it for 1.17 but for 1.17.1. I'm currently in the hospital with cancer and I don't know how long it will last. But after that we can see.
@resi23 don't worry about that then. I hope you get better 🤞
@NiklasEi Since I still have to do chemo, I won't find the time to do it at the moment. I sent you an email with my previous code to gix@xikx.me
I got it and will look at it soo. Thank you.
I hope it helps you a little, most of it is probably just a hoax, but it worked for me.
I took a look at your changes and they seem to be the same I did for 1.17 last year: 66fb5c0ded4134f96a3a0a36524a20c4af649f96
If the remapping works correctly for you and the utilities work, then that should be it. All I remember from last year is that the whole remapping topic confused me and I wasn't sure if I was doing it correctly.
Update: I got gamebox running on 1.17.1, but the game menus are a bit broken. They appear empty until you click in a slot with a (hidden) item.
Update 2: fixed the inventory updates and uploaded a test build for 1.17 support on the Discord server :partying_face:
cool then only 1.18 and 1.19 are missing :/ :D I still have at least 3 months of chemo and can't concentrate on such big things at the moment. When that's over I'll be happy to help again if it's still necessary.
There is a new test build on Discord. The plugin now starts up for all MC versions up to 1.19.2, but has issues on 1.19. For some reason, I cannot get the gamebox commands to work. There are no error logs, but the commands do not get recognised. If you open the GameBox menu through other means like the hub item everything works as expected.
I should come out of the hospital on Monday, then I'll see if I can get it to work
can you push nmsutilities 1.5.0 to your maven repo ?
can you push nmsutilities 1.5.0 to your maven repo ?
Done
I can't explain why the command isn't working.
i did some testings with the Version from discord today.
what works on 1.19.2 (paper latest version) is using the command gamebox and gb (just the gba doesnt work) for example /gamebox cookieclicker or /gb cookieclicker starts the cookieclicker game.
so it looks more like there is a problem with this gba command
may it was a problem of old paper that the commands didnt work on 1.19.x?
Im so happy that we can offer our players the gamebox games aggain <3
...what the... one day later and the commands disappeared aggain from command suggestion and also can be used when typed into chat.
luckly i bound the gamebox command to some citicenz and when i click on them they work.. while in chat they seems to be not registered anymore for command usage in chat..
the npcs still work ...even if they just do the same (they do or do they executed in an other way then a player does?)...... so strange
Here u see the citicenz You see the minigame opened
now same try with the chat command...
so strange..i dont know why the command snytaxmoved over night away?... but the attachment in the citizens works.. here you can see the command that get executed by the npc when you leftclick or rightclick him...
commands:
'0':
command: ptimer give <p> WeltAktion gamebox.use 2
hand: RIGHT
player: false
op: false
cooldown: 0
globalcooldown: 0
n: -1
delay: 0
'1':
command: gamebox tictactoesingle
hand: RIGHT
player: true
op: true
cooldown: 0
globalcooldown: 0
n: -1
delay: 1
'2':
command: ptimer give <p> WeltAktion gamebox.use 2
hand: LEFT
player: false
op: false
cooldown: 0
globalcooldown: 0
n: -1
delay: 0
'3':
command: gamebox tictactoesingle
hand: LEFT
player: true
op: true
cooldown: 0
globalcooldown: 0
n: -1
delay: 1
Oh wow...
That is some strange behaviour you see there, thanks for the info. I just remember that the gb
and the gba
commands did not work for me.
I also had it once that the gamebox command suddenly worked for me without having done anything (paper server). One server restart later but not anymore. It's really very weird
We use a plugin called CMI with this we can create things called "Custom Alias" i crated one...
test:
Cmds:
- gamebox gemcrush
while the gamebox command does not work ingame chat and is also not shown... when i use /test is works.. and gemrush starts...
So may question aggain for two player invations.. is there a command like /gamebox accept? because then we could create a custom alias for that..
If the commands to open the GUIs work, you can open the invitation GUI and click on the head of the player that sent the invite.
I think the accept works via commands, but as far as I remember, some IDs are needed to accept it, so the commands are not nice to use manually. They are just triggered by clicking on the message (if that would work...).
well may i am blind...but could you show me a little video or screencapture where i can find this menue for the invations? if i could find it, it would create an npc that our players could click that leads them to the invations menue to accept an invite. because the clicking on chat does not work for us (the players cant click it)
i closed ticket now because it works in 1.19. for 1.19.4 support i created a new ticket.