NiklasGollenstede / epub-creator

Firefox add-on that creates .epub books from the about:reader and overdrive books
Mozilla Public License 2.0
57 stars 9 forks source link

error when converting some pages #9

Closed TomasEkeli closed 3 years ago

TomasEkeli commented 3 years ago

getting an error that says global.crypto.subtle is undefined on some pages

e.g. http://distributedweb.care/posts/who-owns-the-stars/

NiklasGollenstede commented 3 years ago

Apparently some cryptographic functions are not available on insecure pages, e.g. those without HTTPS 🔒. I never encountered that.

I wrote a fix that avoids using those (here non essential) functions when not available. But Mozilla's extension signing times out, so I currently can't publish it 🙄

Alternative for now: use HTTPS (which the example page supports)

NiklasGollenstede commented 3 years ago

A couple attempts later, and the CI build works again. The update is in the DEV channel now.