search

NiklasGollenstede / unload-tabs

WebExtension that unloads tabs and prevents tabs from loading
https://addons.mozilla.org/addon/unload-tabs/
Mozilla Public License 2.0
69 stars 13 forks source link

Add unload subtree menu item #2

Closed char101 closed 7 years ago

char101 commented 7 years ago

Adds an unload tree menu item for tree style tab.

menu

NiklasGollenstede commented 7 years ago

Looks very good again.

With now three menu items, it was time for some restructuring in that section though: 7685c616ca6ef487549a6849784a727308eea579

Also, the unloadTab function is still buggy: Before: screenshot - sep 27 2016 12 11 pm After unload (of the entire tree): screenshot - sep 27 2016 12 08 pm The very last tab of the tree tends to end up as a top level tab if it was previously nested. If there is another tab beneath it, this doesn't happen.

Also I saw it swap subtrees.

Would you care to debug this?

char101 commented 7 years ago

Hi,

Unfortunately I cannot reproduce this behavior.

Before a

Click unload other tabs b

After c

NiklasGollenstede commented 7 years ago

Damn, I uploaded the images in the wrong order -.-

Before needs to be after, and after before:

The very last tab of the tree tends to end up as a top level tab if it was previously nested.

In your setup it won't happen. Sorry for the confusion.

char101 commented 7 years ago

Thanks for the clarification. I can reproduce the bug sucessfully :ok_hand:.

NiklasGollenstede commented 7 years ago

Well, that's just awesome, or not ...

Anyway, are you looking into this?

And if you do, I think you should open an issue for this.