NiklasPfister / adaXT

adaXT: tree-based machine learning in Python
https://niklaspfister.github.io/adaXT/
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

Move predict_proba into predict #86

Closed NiklasPfister closed 1 month ago

NiklasPfister commented 2 months ago

The predict_proba method was included to be close to sklearns interface, however given that it is specific only to the classification trees it seems that it is better directly included in the PredictClassification class such that it can be invoked by specifying a kwarg.

NiklasPfister commented 2 months ago

When fixing this be aware that there is currently a bug when calling predict_proba for a classification forest with n_jobs > 1.

svbrodersen commented 1 month ago

This is now fixed as part of the update RandomForest PR on Development branch