search

NiklasRosenstein / flux-ci

Flux is your own private & lightweight CI server.
MIT License
26 stars 10 forks source link

repository.owner.name -> repository.owner.login #26

Closed steinnes closed 8 years ago

steinnes commented 8 years ago

This should fix #25

steinnes commented 8 years ago

I did this change separately from master, but I have some more goodies on another branch locally. Mostly docker support (I have an ubuntu 14.04 based linux machine which I am using for development, so I decided to write the Dockerfile to be able to work with flux from ubuntu 16.04 for a newer, supported, git version).

I am having some other issues with GitHub... I'll show you @NiklasRosenstein when I'm done and we can see if you want to merge any of those changes.

NiklasRosenstein commented 8 years ago

Just to check since you said "should fix": Were you able to verify that it's working now? I can't test it atm.

NiklasRosenstein commented 8 years ago

Mostly docker support

Awesome! :grin: Looking forward to that, thanks.

steinnes commented 8 years ago

The change on my branch is slightly different, I'll test this one there and let you know!

steinnes commented 8 years ago

Ok, glad you asked about whether I tested that, because I just did and the payload seems different based on the type of event from GitHub (or something). This branch breaks in other scenarios.

image

steinnes commented 8 years ago

This version has been tested. I'm rebasing the docker branch to use it (as the docker branch is the one I am able to test easily here at home ;-).

steinnes commented 8 years ago

This was my misunderstanding, I didn't see anywhere that only push events were supported, and the existing code seems fine for those. Let's skip this since flux does not support other events (and it's not even particularly straight forward to detect the event type, at first glance).