search

NiklasRosenstein / flux-ci

Flux is your own private & lightweight CI server.
MIT License
26 stars 10 forks source link

Changed filename pattern for build artifact and log downloads. #37

Closed tvrzna closed 6 years ago

tvrzna commented 6 years ago

I've experienced the issue, when I have downloaded two build logs from different projects. Because I was in hurry, I was confused, which is which.

For this reason, I've decided to use existing functionality for definition of filename to be downloaded. Selected pattern is group_name-buildnumber.extension. Since / is forbidden character, it is replaced by _. Extension is defined in the same way as mime type.

So result could be e.g. NiklasRosenstein_flux-10.zip or NiklasRosenstein_flux-11.log.

NiklasRosenstein commented 6 years ago

Great -- thank you! You should create a CONTRIBUTORS.txt and add yourself there. :-)

tvrzna commented 6 years ago

It's not about being mentioned in CONTRIBUTORS.txt, it's about help to improve Flux :)