Closed tvrzna closed 5 years ago
That would be quite an overkill, those values are Enum, so standard usage is with enum name. The default value is GitFolderHandling.DELETE_BEFORE_BUILD
. Maybe the enum could have better name.
LGTM, but could you move the enum definition into a module other than flux_config
? (Because it is intended to only supply configuration values, not any types that are part of the config's logic)
That's a good point. I'll create common enum module later today, as soon as I get to my computer.
Last year I had mentioned, that in some cases it could be required to have .git folder during build (e.g. enhancing application version). For this specific reason I've added new configuration named
git_folder_handling
. This config could be set to three options: