NiklasRosenstein / flux-ci

Flux is your own private & lightweight CI server.
MIT License
26 stars 10 forks source link

Added setting, that defines, at which point should be .git removed. #64

Closed tvrzna closed 5 years ago

tvrzna commented 5 years ago

Last year I had mentioned, that in some cases it could be required to have .git folder during build (e.g. enhancing application version). For this specific reason I've added new configuration named git_folder_handling. This config could be set to three options:

tvrzna commented 5 years ago

That would be quite an overkill, those values are Enum, so standard usage is with enum name. The default value is GitFolderHandling.DELETE_BEFORE_BUILD. Maybe the enum could have better name.

NiklasRosenstein commented 5 years ago

LGTM, but could you move the enum definition into a module other than flux_config? (Because it is intended to only supply configuration values, not any types that are part of the config's logic)

tvrzna commented 5 years ago

That's a good point. I'll create common enum module later today, as soon as I get to my computer.