Chatroom No. 3

[NikoKrause]

Room for discussion...

[NikoKrause]

@cinnamoner @feren @Odyseus @BigDaddyonTech @lestcape @mintystark @Elbullazul @germanfr Finally I uploaded the CinnVIIStarkMenu on Cinnamon Spices. It's already on the Spices Website and will be soon available through System Settings > Applets > Available Applets (online). This will probably take some time (a few minutes/hours). I wanted to thank you for your help and all the nice feedback. Without you, the applet wouldn't be by far, what it is today. It has been a long ride and it needed much work and time. For the next few weeks/months I won't be not much around. Only updating what is necessary (translations, critical bugs). But it will take, till I have time again to implement new features. You are still welcome to report bugs and create feature requests. It was a lot of fun to work on this applet.

[ghost]

@NikoKrause congratulation... There are not better things that see somethings working with your enforce, and always it's better when you see a lot of people helping to to create the dream...

[ghost]

That's old...

[NikoKrause]

The menu has been improved. Now, when you change themes the height of the menu is seized properly. Before that a jump was visible, when you switched between All Programs and Favorites.

Also the searchbox looks slightly better now. Thanks to @germanfr

@Elbullazul You can translate it into French, if you want to.

[Elbullazul]

@NikoKrause ok, what's the translation file again?

[NikoKrause]

It's best to translate here https://translations.launchpad.net/cinnviistarkmenu/trunk/+pots/cinnviistarkmenu/

[Elbullazul]

@NikoKrause done, submitted the missing translation objects

[NikoKrause]

Thank you very much. I'll upload it tomorrow.

[NikoKrause]

@germanfr @Elbullazul @muzena @giwhub @Radek71

I added a feature to hide the user picture. Now the translations need to be updated ;) (5 new strings to translate) here: https://translations.launchpad.net/cinnviistarkmenu

If you have time, I'd appreciate the help.

P.S.: If you don't have a launchpad account, you can post the translations here. I'll add and update them as soon as possible. It's easier than to create a new pull request.

[Radek71]

updeted Czech translation is attached

radek

---------- Původní zpráva ---------- Od: NikoKrause notifications@github.com Komu: NikoKrause/CinnVIIStarkMenu CinnVIIStarkMenu@noreply.github.com Datum: 18. 3. 2017 14:49:11 Předmět: Re: [NikoKrause/CinnVIIStarkMenu] Chatroom No. 3 (#21)

" @germanfr(https://github.com/germanfr) @Elbullazul (https://github.com/Elbullazul) @muzena(https://github.com/muzena) @giwhub (https://github.com/giwhub) @Radek71(https://github.com/Radek71)

I added a feature to hide the user picture. Now the translations need to be updated ;) (5 new strings to translate) here: https://translations.launchpad.net/cinnviistarkmenu (https://translations.launchpad.net/cinnviistarkmenu)

If you have time, I'd appreciate the help.

P.S.: If you don't have a launchpad account, you can post the translations here. I'll add and update them as soon as possible. It's easier than to create a new pull request.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/NikoKrause/CinnVIIStarkMenu/issues/21#issuecomment-287547480) , or mute the thread (https://github.com/notifications/unsubscribe-auth/AT7ho5ibB5nESXAflr0FyrA0hCdMOx40ks5rm-DSgaJpZM4L4OAS) .

"

[NikoKrause]

@Radek71 Thanks, but where do I find the attachment?

[Radek71]

@NikoKrause

:-) seems that hands are faster than head... CinnVIIStarkMenu@NikoKrause_po_CinnVIIStarkMenu-cs(1).po.zip

[germanfr]

:white_check_mark: Updated Spanish on launchpad.

[NikoKrause]

Gracias

[giwhub]

Updated Chinese Translation:

https://raw.githubusercontent.com/giwhub/CinnVIIStarkMenu/giwhub-patch-1/CinnVIIStarkMenu%40NikoKrause/po/zh_CN.po

[NikoKrause]

非常感谢 (Thank you very much)

[NikoKrause]

1. Yeah. That's a big issue. Since they did vertical panels I hope the next big change will be desktop grid. It's a well known issue since years.

I don't care for the rest. Mint-Y has nice close buttons. Although red would be better than green.

[dominichayesferen]

@NikoKrause Agreed on the Close Button colour

[dominichayesferen]

@NikoKrause @Elbullazul Been brewing up an idea lately that may be possible with CinnVIIStarkMenu to get a More Aero-esque look for the Aero themes by Elbullazul, it goes like this: If you can give the menu a blank row of pixels at the top of the menu image, and then make that row be stretched down far enough to make it go to the position of the user picture that Windows 7 has the menu and the user picture, then you could get a Windows-7-esque menu in theory, if you then managed these tweaks:

1. Managed to put a blank space over the favourites list to make it go down to look like it's in the Menu still
2. Same thing for the All Programs View

If this is executed correctly, you could, in theory, get the illusion of the user picture sticking out of the menu, like in Windows Vista/7...

[dominichayesferen]

Here's a half-baked attempt at trying to get a more XP-esque look by using this theory to move the user picture up to the blue bit, and move the buttons to their respective places in the XP Menu...

Theme Used: CinnXP To-do for anyone who wants to attempt it:

• Bring back the blue bar bit, but without causing it to overlap the top bit
• Move the user picture further up, and the Power Button and the Search Bar down
• Make sure All Programs is still in the white bit...

[dominichayesferen]

...and this is the same thing, but done to Windows Se7en (I can't push the favourites/application menus down without moving the user picture, any ideas @NikoKrause ?) To-do for anyone who wants to attempt to get it working:

• Move the user picture up further so that there's exactly 25 pixels (if the user picture is the size it is in Windows 7) between the Start Menu Background, and the top of the user picture
• Move the favourites/app-programs menus down into the "menu" again

[dominichayesferen]

...and here's the two themes in case you want to try your hand at this, it'd be good if someone can get it more authentic position-wise: Theme Attempts.zip

[dominichayesferen]

@lestcape Shall I invite Joe Sneddon here with an @ mention?

[ghost]

@feren i don' t know why not? He is not my friends or my enemy so... ask to @NikoKrause This is his repository not?

[NikoKrause]

Who is it?

[NikoKrause]

@Odyseus Do you think you could add an option to cinnamon-json-makepot, which updates the existing po files against the pot file? It's possible with msgmerge, but it would be nice having it in cinnamon-json-makepot

[dominichayesferen]

@NikoKrause Joe Sneddon: Writer of articles at OMG! Ubuntu, also a Stargazer of @lestcape 's Cinnamon and GNOME LIM Applet/Extensions, and he's reported on them both...

[Odyseus]

Hello, everybody.

@NikoKrause: I don't think that it will be useful nor needed. For the simple fact that updating all .po files against the template (.pot file) is only needed if you are going to also translate all the new strings. And a translator that will be working on updating a .po file should be using Poedit (you already experienced the problems caused by .po files edited manually), which already has the ability to update the .po file from a template.

[ghost]

@Odyseus how you update the po file then? I always make this by hands, like always it's one more option only, but i think what you considered not useful it's the way to update po....

[Odyseus]

@lestcape

how you update the po file then?

I already specified in my previous message how to. Using Poedit.

I always make this by hands, ...

Like I said, there is no point in updating the .po files from a .pot file if you are not going to translate the new strings. And the only ones that should do that are the authors of the translations. And like I pointed out to NikoKrause, updating manually isn't recommended and is prone to errors. He already had to correct various .po files on the Spices repository. A thing that would never had happened if the right tool were being used.

Me, as the author of an xlet, should only modify the template (the .pot) file and the .po files that I'm the author of. I should stay away from all other .po files from other languages since updating them from the template serves no purpose. Simply because I cannot translate the new strings since I most likely will not understand the language.

[ghost]

i understand your point now... I never have a lot of file, but actually i have a lot and i need to change my decision of update the file manually, because it's now not easy.

[NikoKrause]

I disagree. It can be hard for a translator to follow up, if there are new strings to translate. E.g. you have to check 20 po files, if they contain untranslated strings. The first thing he has to do is to update them against their pot file.

Therefore if the dev does this, he can just check the po files for new untranslated strings.

@lestcape You don't have to do this by hand. If you updated your template .pot file, just use the command

msgmerge --update --backup=off LANGUAGE.po TEMPLATE.pot

[NikoKrause]

@Odyseus

He already had to correct various .po files on the Spices repository. A thing that would never had happened if the right tool were being used.

What I had in mind was to update po files, which were already created with poedit. What I did on spices, was to remind the translator to use a proper editor to create this file. If it's already created, he can also translate it in any editor he likes (gedit, xed, etc.)

[Odyseus]

Hello, everybody.

@NikoKrause

It can be hard for a translator to follow up, if there are new strings to translate.

It isn't hard if the right tool is used.

E.g. you have to check 20 po files, if they contain untranslated strings. The first thing he has to do is to update them against their pot file.

If I had 20 .po files in one of my xlets, like I said, I would stay far away from them. And again, like I said, the translators should be the only ones that should update the .po files. Is as simple as:

• Open the .po file with Poedit.
• Go to Catalog > Update from POT file....
• Press Ctrl + Enter and go straigth to the first new untranslated string (if any).
• If the new string is in the translation history, use it. If not, translate it and it will be saved in the translation history for future use.
• Press Ctrl + Enter and go to the next new untranslated string (if any). Repeat as needed.

If it's already created, he can also translate it in any editor he likes (gedit, xed, etc.)

That's just promoting bad habits. Using any editor other than Poedit (or similar tools) is just a waste of time.

[ghost]

@NikoKrause i agree with @Odyseus but not in the part of update po files from pot in poedit. I think it's more easy for translators if you update his po files first and let then only the task of translate it. msgmerge like you say it's the way.

[ghost]

Edited: @NikoKrause if you want use this tools that i make: https://github.com/jake-phy/WindowIconList/blob/master/WindowListGroup%40jake.phy%40gmail.com/locale/localeUpdate.sh

It's an extension of cinnamon-json-makepot, to do this task automatically.

Revert the line that was introduced as it's for this extension only.

[dominichayesferen]

@NikoKrause Got this issue which is related to your Start Menu, does it affect your menu upstream too? https://github.com/feren-OS/feren-OS-Bug-Reporting/issues/9

[ghost]

I will try to port cinnamon-json-makepot for gjs/cjs to be used in my extensions, and i will add this feature to my tools.

[NikoKrause]

I disaggree. As translator you update 20 po files to realize, that only 2 had new Strings to translate.

But anyhow. No need to discuss it any further.

[NikoKrause]

@feren: Where is your code?

[dominichayesferen]

@NikoKrause What do you mean?

[NikoKrause]

@feren The bug report is for a certain StarMenu. Where do I find the code for this Menu, of which the issue appears? The repository is empty.

I think I know what's going on, but I have to see what's in the code.

[ghost]

@NikoKrause you update 20 po file AUTOMATICALLY to only translate 2 had new Strings

[ghost]

@NikoKrause isay my tools make it AUTOMATICALLY

[NikoKrause]

@lestcape No. It was only an example. I just wanted to point out, that I think the dev should update the po files, if he can. Therefore the translator just needs to open a po file and see instantly, that new strings are available to translate. I see some advantages for the translator, if he has not to update the po file. And I don't think the translator would have disadvantages, if the dev does this. It's less work for the translator.

[ghost]

@NikoKrause and i agree with you in that and i tell you that this is exactly what is doing the script that i make... and of course this can be moved to cinnamon-make-pot easy and will be good to have that and i dislike the way of update the po on poedit that @Odyseus propose ofcourse. But i agree with him update po file manually it's not a good, and never do that.

[dominichayesferen]

@NikoKrause It's the one in 2017.0 RC... Version 1.3 from Cinnamon Spices

[NikoKrause]

Can you provide a link?

[ghost]

Anyway, yours are adding a translations to all extensions in cinnamon against yours owns rules.

"Pull requests from other people

In addition to the checks specified above, if the pull requests comes from somebody else than the author, the reviewer will need to check the nature of the changes.

If the changes represent a bug fix, the PR can be merged.

If the changes represent a change in functionality, or in look and feel, or if their implementation could be questioned and/or discussed, the reviewer should leave the PR open and ask the author to review it.

If the author is happy with the PR, it can then be merged. If he's not, it can be closed instead."

[NikoKrause]

It depends. You can argue, if it's an issue/bug, if a user installs an applet and can't use it, because he doesn't understand a word.

Translations do not change the functionality of an applet. If it changes the feel of an applet, depends on your definition of "feel".

Most likely, if you find an English word/sentence in Cinnamon, while everything else is in your current language, you would consider this to be a bug. I at least have a feeling that it's a bug when I read something like: " The computer is turning of in 10 Sekunden."

But I don't want to argue about it.

Maybe you have a point. It the README could be more specific, that translations are considered to be bugs.