Closed scottycam closed 6 years ago
Hello, regarding the issue u were facing it was fixed in the latest version of nikolag/core package, you can look at the latest version and what was fixed here. Try downloading/updating to the latest version and closing this issue if it resolves ur problem.
I'm glad I was able to contribute :)
Amazing response speed :)
This does fix my problem. However installing the Square package via composer seems to always use core v1.0 (which has the typo). I can manually update core by changing the version in composer.json to 1.0.2 and "composer update" however this causes it to trigger the minimum stability issue warning for the square package stating it requires core v1.0 and wont allow the update. Manually updating Core to 1.0.2 fixes my issue though but wasn't able to achieve the update via composer
New install of either core or square packages are installing core 1.0 instead of the updated 1.0.2
Hmm, can you try doing composer clearcache
and then doing composer update
? If this doesn't fixes the issue, I'll push a fix immediatelly
I ran both those commands and had the same issue.
if it helps at all changing the composer.json version of core to 1.0.2 and running composer update. This is the error.
Your requirements could not be resolved to an installable set of packages.
Problem 1
@scottycam I've just pushed a fix, it passes the tests and installs v1.0.2 of nikolag/core package, could you confirm this actually fixed ur issue?
@NikolaGavric94 I just ran composer update and it didn't update to core 1.0.2. I ran composer clearcache and tried again but same thing.
To test I installed a fresh copy of laravel 5.5 and ran "composer require nikolag/square --dev" to install nikolag/square
it installed nikolag/core as a dependency but it installed core version 1.0.0 that has the typo. Does the composer.json file for nikolag/square containing the line "nikolag/core": "1.0.0" under "required" need to be update?
@scottycam Fresh install should be installing the latest version, because ^1.0 is supposed to install the version >= 1.0 < 2.0.0
as in https://getcomposer.org/doc/articles/versions.md#caret-version-range-,
and in the tests that were ran 8h ago it did indeed install as u can see in the image below..
I'll start a fresh project myself too and i'll try to locate the issue
@scottycam i've just tried to clearcache and run composer install
I think you should be fine now, try updating the dependencies with composer update
and if that resolves the issue, please close the issue
Running "composer update" again this morning and it updates correctly. Also tested on that fresh laravel installation I made before deleting it and updated that too, so all good. Thanks @NikolaGavric94 for helping me and fixing the issue so quickly :)
I added the package to my project, setup and migrated. However running the migration command fails.
I am using MySQL ver 14.14
The failure was caused by this line in the "create_nikolag_customers_table" migration.
"$table->string('payment_service_type', 25)->unsigned();"
From my understanding you can't unsign a string. Removing "->unsigned()" fixes my issue.
ps. Thanks for the package, it is going to save me a lot of time.