search

NikolaLohinski / terraform-provider-freebox

🔌 A terraform provider to interact with a famous French ISP box
https://nikolalohinski.github.io/terraform-provider-freebox
2 stars 2 forks source link

Implement resource VM import #2

Closed gbloquel closed 3 months ago

gbloquel commented 3 months ago

Hi,

This PR allows to import vm resource.

Regards,

gbloquel commented 3 months ago

hi @NikolaLohinski,

After reading the CI logs it seems that the variable FREEBOX_ENDPOINT is not interpreted during the test.

failed to perform request: Get "http:///api//login": http: no Host in request URL
NikolaLohinski commented 3 months ago

Hi @gbloquel

Thank you very much for the contribution, it's great to see that so early in this project, some people are already interested.

Regarding the failing CI, it has nothing to do with your changes indeed. I am having some trouble with GitHub action sometimes picking up the environment variables and sometimes not... I tested your stuff locally and it looks fine so far. Will merge ASAP and cut a new release.

Thanks again, and feel free to continue contributing, it is very much appreciated :pray:

PS: I'll be adding the IPv4/6 VM attributes soon and will work on port forwarding resources as well so stay tuned.