search

NikolaiVChr / Autinn

Autinn VCV Rack plugin
GNU General Public License v3.0
19 stars 0 forks source link

Rack v2 #14

Open pgatt opened 2 years ago

pgatt commented 2 years ago

Hi there,

I use your modules a bunch in Rack v1, just wondering if you are going to convert them over to VCV 2?

Thanks!

NikolaiVChr commented 2 years ago

I kinda left them to collect dust, as they were not very popular.

But since there is at least one user, I might convert them then. :)

Will keep you updated.

pgatt commented 2 years ago

That would be great, thanks!

pgatt commented 2 years ago

For what it’s worth - at least one other user on the community forum is keen to see your modules make the transition, I suspect there would be a few others.

NikolaiVChr commented 2 years ago

I have just made the source-code open-source. Someone has already offered to port it to Rack v2.

The code does not have lots of comments, and those that are there might be outdated.

And sorry for all the IF statements in Bass module. Probably not much fun to read that code.

pgatt commented 2 years ago

I just built your plugin out of curiosity. Are you sure you don't want to maintain control of your plugin? It transferred to v2 literally by changing the rack version in plugin.json to 2.0.0

NikolaiVChr commented 2 years ago

Oh? I thought it would require tons of deep changes, didn't look into it.

Since I open-sourced it a couple of hours ago, I actually toyed with the idea of continue to work on it. Must admit. But I don't have MacOS, so I cannot even build it for Macs. Have to use Linux subsystem in Windows to build the Linux version, as I have no Linux installed.

Don't know, I said Steve Russell could have it. Not sure if he planned to just update it to v2 or do other stuff with it.

SteveRussell33 commented 2 years ago

I was just going to port it over to v2 for the time being. Looks like there wasn't anything to do in the way of API changes as @pgatt mentioned in his post. That saves me some work! lol

I'd like to extend my thanks to you as well for opensourcing your modules as I'm a old user as well - what's that 3 of us now? Haha

Would be great if you continued to work on them when you can, although as a reminder you would have to add me as a repo Contributor - that way I could commit directly to the codebase. Otherwise you would have to see and merge manually any PR I or someone else makes.

pgatt commented 2 years ago

@NikolaiVChr, Up to you either way, just thought I would let you know as it was only a one line fix - I have a Mac and can build for you if necessary, but there are workarounds too - I believe some devs have done a few different methods to achieve this, if I recall corrrectly one dev even uses Github actions to build for the other two platforms that he doesn't have.

NikolaiVChr commented 2 years ago

That sounds interesting, I will look into that. And thank you for the offer.

I am doing the conversion to Rack v2 now.

NikolaiVChr commented 2 years ago

I got the github actions to work now. Both for Rack v1 and for Rack v2 branches.

V2 is built using rack beta 1 SDK.

From: https://community.vcvrack.com/t/automated-building-and-releasing-plugins-on-github-with-github-actions/11364

NikolaiVChr commented 2 years ago

v2.0.0 is now released. And I have notified VCV Rack to include it in the library as open-source. Thank you @SteveRussell33 for your help. And @pgatt for waking me up so this could be done.