Change keys for GCI/ejection

NikolaiVChr / flightgear-saab-ja-37-viggen

Saab 37 Viggen for Flightgear flight simulator

http://wiki.flightgear.org/Saab_37_Viggen

GNU General Public License v2.0

27 stars 15 forks source link

Change keys for GCI/ejection #108

Closed colingeniet closed 4 years ago

colingeniet commented 4 years ago

F6 is ejection, F7-9 is GCI. As you can imagine, this results in unwanted ejections when using GCI.

Any suggestion on a better choice of keybindings?

JMaverick16 commented 4 years ago

F8>F10 maybe?

Rudolf339 commented 4 years ago

Idk what the F-16 uses, but the MiG-21 uses f5-7 for GCI, it would be nice to make it standard. For the ejection I would make it say shift+f8 so you can't really hit it by accident

colingeniet commented 4 years ago

F10 toggles the menubar, that's not a keybinding I want to mess with, even if most people generally don't use it.

Here's the current keys for some of the other aircrafts:

f16 and f14: ejection F6, gci ctrl 1-3
m2000: ejection ctrl-E x3, gci F6-F8
mig21: no ejection, gci F5-F7

Viggen uses ctrl 1-8 to select pylons. I think these keybindings are fairly obsolete and not really realistic (irl, AJS uses a knob to select weapon type, JA can select pylons on the TI, and has 'shortcuts' on the throttle). Maybe they could be deleted to have the same control scheme as f16/f14.

Rudolf339 commented 4 years ago

Yeah, same as the f-14/16 sounds the best. Though making ejection shift+F6 would be nice, just in case

NikolaiVChr commented 4 years ago

Yeah, I agree that the pylon keybindings are obsolete.

colingeniet commented 4 years ago

Pylon keybindings are removed, GCI is now ctrl 1-3

making ejection shift+F6

I like the idea of a 'safer' ejection shortcut, but since F6 is used by several aircrafts, I think it would be better to change it consistently, and thus discuss it more publicly.

colingeniet commented 4 years ago

Reopening the issue because I just realised that the keybindings ctrl-2 and ctrl-3 are completely broken for me:

ctrl-2 seems to do the same as ctrl-1 (and it's not because I made a copy/paste error in the keybindings file)
ctrl-3 seems to generate ESC (it will give the 'Exit Flightgear' prompt dialog, or close the active dialog if any)

Since it has to do with keyboard input, I suspect it may also be OS dependent. I'm using linux (X11). It would be helpful if other persons could test this, including using other OS.

The GCI keybindings set one of the three properties in /instrumentation/gci each, it's the easiest way to check if they work.

colingeniet commented 4 years ago

Unless someone objects/has a better idea, I am leaning towards the following changes:

F5-F7 for GCI, same as MiG-21
Ctrl-E x3 for ejection (from the mirage), which I think is a really good way to have a 'safe' shortcut.

colingeniet commented 4 years ago

https://github.com/NikolaiVChr/flightgear-saab-ja-37-viggen/commit/66350b651c4aa201096fb15e25a69c33f00baba6