search

NikolaiVChr / flightgear-saab-ja-37-viggen

Saab 37 Viggen for Flightgear flight simulator
http://wiki.flightgear.org/Saab_37_Viggen
GNU General Public License v2.0
27 stars 15 forks source link

Redundant shaders #123

Closed colingeniet closed 4 years ago

colingeniet commented 4 years ago

Since the shaders need to be ported to Compositor/debugged (#122), I am very much interested in reducing the number of custom shaders which we have.

Many of the shaders we have (e.g. noise.frag, glass-ALS.{vert,frag}) are identical to the ones in fgdata. Is there any issue with removing these?

NikolaiVChr commented 4 years ago

They are there because I wanted the effects before the official release in FG.

So no should be fine to remove.

But not the thrust effect, its modified, so that that it shows heatblur.

colingeniet commented 4 years ago

They are there because I wanted the effects before the official release in FG.

That's more or less what I suspected, thanks for confirming.

I will make sure to keep thrusthead-ALS.{frag,vert}. What about the shaders under Models/Effects/fuselage, and displays/lcd.{frag,vert} ? Are they modified versions? Everything else seems to be duplicate.

NikolaiVChr commented 4 years ago

fuselage and display are my shaders.

fuselage is a heavy modified model-combined display is a shader I made from scratch

NikolaiVChr commented 4 years ago

As for the other shader beside those 3 I dont remember if I made changes. Will just have to diff them.

colingeniet commented 4 years ago

Yes, I just checked, there are no differences for the others.

colingeniet commented 4 years ago

Correction, light-fixed.frag and thrustflame-ALS.frag also has some changes.

NikolaiVChr commented 4 years ago

Oh yeah, I made that work in non-als.