Engine sounds are broken

[colingeniet]

Steps to reproduce:

• In cockpit view, start up / increase throttle -> engine sound audible
• Switch to external view, then back to cockpit view -> some engine sounds are missing
• The sound restarts at least in the following conditions:
  • the sound condition is cycled (off / on)
  • pausing and resuming FG

[colingeniet]

I half-understand this bug. It is related to the 'avionics sounds in external views' setting. The bug only occurs when this is off (avionics in internal views only). The combination of avionics sound effects and manually testing /sim/current-view/internal is problematic.

I think the following needs to be checked (for all sounds):

• [x] Only use <type>avionics</type> for actual avionics, otherwise we break the sound settings (changing 'avionics' setting doesn't do what the user expects)
• [x] Do not test /sim/current-view/internal for sounds tagged as avionics. It is redundant with the sound setting, and apparently buggy.

[colingeniet]

Fixed in https://github.com/NikolaiVChr/flightgear-saab-ja-37-viggen/commit/28c9efb14dcadada0c929c9b9961789f7d1198f5, https://github.com/NikolaiVChr/flightgear-saab-ja-37-viggen/commit/020fd8384485533bcf8eff8d41be95b86fb09884