search

NikolayRys / Likely

The social sharing buttons that aren’t shabby
ISC License
395 stars 61 forks source link

Yandex.Collections share button #111

Closed jakwuh closed 7 years ago

jakwuh commented 7 years ago

Hi!

First of all, big thanks to all of the contributors for making nice and easy to use social buttons.

It is half a year since Yandex.Collections has launched and now it offers some great options for content discovering, bookmarking and sharing.

I've failed trying to find any contribution docs so I'd like to know if it is ok to prepare a PR for adding the social button?

vitkarpov commented 7 years ago

@iamakulov Hey, what do you think? Seems we need design of a new button, don't we?

iamakulov commented 7 years ago

Pinging @ilyabirman for the opinion on the button.

Also, I've just enabled the email notifications, so I won't miss the future issues and PRs :D @vitkarpov, thanks for pinging!

iamakulov commented 7 years ago

Discussed this. @jakwuh, I'm sorry, I think we won't be adding this button for now, but we may return to this in the future. Anyway, your question is important: we see that there're people that need a specific button, and we start considering it – so thank you for the interest!

I've failed trying to find any contribution docs

Yeah, it's a major problem: I don't get enough time to write the docs, and it's probably also unnecessary at the moment because I plan a major refactoring in the near future. We'll get to this sooner or later (we even have #17 for this 😅).

jakwuh commented 7 years ago

@iamakulov thank you for your response. Though this issue is closed, please, let me know if you open somehow in a future releases the possibility to opt-in social buttons (perhaps not such popular worldwide but still important to some audience).

iamakulov commented 7 years ago

Okay! Can't promise because I can forget it, but if I remember I'll surely notify you.