NikolayRys / Likely

The social sharing buttons that aren’t shabby
ISC License
395 stars 61 forks source link

Hides random functions behind the likely namespace #127

Closed vitkarpov closed 7 years ago

vitkarpov commented 7 years ago

@iamakulov

vitkarpov commented 7 years ago

likely seems like a pretty generic name that could be overridden by an occasion

@iamakulov Are you sure? likely is our namespace, where the whole library lives.

iamakulov commented 7 years ago

But there're other usages of likely outside of other library because it's a generic English word. E.g. someone could call a global variable with this name. That's why I'm for a more specific name.

vitkarpov commented 7 years ago

Yeah, Likely could be used as commonjs module, I get it. _likelyCallbacks is a good choice :)

iamakulov commented 7 years ago

@vitkarpov, could you please do the changes here? Or please tell if you’re going to return to this later, I’ll keep this opened.

vitkarpov commented 7 years ago

Yeah, sure. I'll finish this.

vitkarpov commented 7 years ago

@iamakulov done, but for some reason tests are failed, not only in this pr. Seems like a problem with Travis, 'cause it started to reproduce recently

iamakulov commented 7 years ago

Thanks! We'll deal with the tests later