search

NikolayRys / Likely

The social sharing buttons that aren’t shabby
ISC License
395 stars 61 forks source link

(fix): defines cache for likely callbacks #132

Closed vitkarpov closed 7 years ago

iamakulov commented 7 years ago

Will this work when the library is imported as a CommonJS module? The CommonJS build doesn’t include the likely.js file, as far as I remember

vitkarpov commented 7 years ago

Good point! I guess it doesn't, we don't have a test or demo page (with commonjs), so I missed it. I think I have to move this into index.js.

iamakulov commented 7 years ago

I’d suggest moving it into dom.js, where this property is actually used (but the choice is yours)

vitkarpov commented 7 years ago

Yep, you're right. Fixed! :)