Closed devxom closed 4 years ago
@devxom Awesome indeed, I've tested it locally and it works perfectly. But only one suggestion - please amend the commit message to follow the same style as all the others.
Here's a comprehensive recap: https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53
@NikolayRys
But only one suggestion - please amend the commit message to follow the same style as all the others.
I apologize, out of habit, I decided that commits when merge to the master will be squashed. Now I reviewed the history of commits in the master branch and realized that I was wrong.
I can do rebase and reformat the commits and messages to them as needed.
@devxom Hi, no news about this? If you wish, I can handle this cleanup on my own if you want, but this might change the recorded commit author, while I would prefer to keep it as your contribution.
@NikolayRys I rebuilt and updated the branch with the master. Is there any need for further adjustments?
@vitkarpov Made changes according to the comment in the message https://github.com/NikolayRys/Likely/pull/164#discussion_r419052560
Looks great! Please check the last two comments from @vitkarpov and me, and it'll be done.
@NikolayRys,
Looks great! Please check the last two comments from @vitkarpov and me, and it'll be done.
Fixed
Add support sharing in reddit.com for #147
Changes:
resolve: #147