search

NikolayRys / Likely

The social sharing buttons that aren’t shabby
ISC License
395 stars 61 forks source link

Vertical margins slightly differ #171

Closed vitkarpov closed 4 years ago

vitkarpov commented 4 years ago

Thanks for the feedback. Also, if you have the opportunity, pay attention to the indentation https://prnt.sc/qt3gmg. The top margin is slightly larger than the bottom. If there is an opportunity to align them and slightly reduce.

Originally posted by @optimist-law in https://github.com/NikolayRys/Likely/issues/145#issuecomment-616089995

vitkarpov commented 4 years ago

@optimist-law are you sure it's not on your website? I'm looking at https://ilyabirman.net/projects/likely/ and there are no margins at all (except negative ones to compensate buttons margins). If you could share your website address I'd take a look. Thanks.

optimist-law commented 4 years ago

An example can be seen here https://bit.ly/2RSzNFw

vitkarpov commented 4 years ago

@optimist-law I see, thanks. The problem is that styles on your page discard Likely's ones, it should've been negative margins there (as I wrote before to compensate buttons margins) but it's zero.

Screen Shot 2020-04-19 at 1 50 29 PM

Do you think it makes sense to fix it on your side?

NikolayRys commented 4 years ago

@vitkarpov thanks for taking care of this 👍

NikolayRys commented 4 years ago

Hi, @optimist-law, I would appreciate it if you give us some feedback about what @vitkarpov has said. Has it solved it?

NikolayRys commented 4 years ago

The reporter is unresponsive, closing the issue