search

NikolayRys / Likely

The social sharing buttons that aren’t shabby
ISC License
394 stars 61 forks source link

Internal rework #183

Closed NikolayRys closed 4 years ago

NikolayRys commented 4 years ago

Fixes #168 Fixes #176

Major internal rework that takes care of several hidden issues, including randomly falling tests, additional requests when the same button appears more than once, name conflicts, and architectural oddness that led to ugly mocking. I hope now it becomes much more maintainable.

Though, no user-facing functionality is expected to change.

@vitkarpov this was the main thing that holded the 2.5 release and the further development of the project, which, fortunately, is done now. I've tested all of that, but could you please give it a look before I merge it and proceed to the other pull requests?

NikolayRys commented 4 years ago

Currently working on the merge conflicts - they are a bit larger than actually visible on git merge.

NikolayRys commented 4 years ago

Also fixed travis build