search

NikolayRys / Likely

The social sharing buttons that aren’t shabby
ISC License
395 stars 61 forks source link

Uncaught TypeError: o.promises[t] is not a function #185

Closed likerRr closed 4 years ago

likerRr commented 4 years ago

Found this error in console on my site along with likelys' home page

NikolayRys commented 4 years ago

@likerRr Thanks for report. However, likely's homepage still uses the previous version - 2.4. Could you please first make sure that you updated it to the most recent one - 2.5? https://www.npmjs.com/package/ilyabirman-likely/v/2.5.0

likerRr commented 4 years ago

Unfortunately it still presents in 2.5.0 too

NikolayRys commented 4 years ago

Thanks, is it possible to share your page then? It would help us with reproducing it.

likerRr commented 4 years ago

What do you mean? I don't have all the accounts, but when I click any of the social button, I got vendor's modal window opened, so it seams working.

image

I think the issue is with counters, but I don't show them on my site.

NikolayRys commented 4 years ago

Indeed this line relates to the displayed number.

You said that "Found this error in console on my site", so I hoped to see your site to probably find out more about conditions when it happens because it doesn't happen every time.

likerRr commented 4 years ago

You can check it out here. Will it help?

NikolayRys commented 4 years ago

Thanks, but not a lot, it's still 2.4 as on the Likely webpage, which is significantly different from 2.5, I was hoping to see it happening with the last version. It's better than nothing but might happen because of different reasons/require a different solution than 2.4.

likerRr commented 4 years ago

You are right, the version in prod is out of date. I tried the updated one on my local machine. For now I can't deploy it

NikolayRys commented 4 years ago

Gotcha, I look into it using the current examples but post the link here please when you have deployed it.

likerRr commented 4 years ago

@NikolayRys hello! We deployed the app with updated likely lib and the error has gone. You can check it here

NikolayRys commented 4 years ago

@likerRr Perfect, thanks for the feedback, that probably explains why I haven't succeeded in reproducing it myself. I'll leave the issue open for a while if anybody experiences it too and can show it.

NikolayRys commented 4 years ago

I guess, we don't need this one anymore