search

Nikoleta-v3 / Thesis

A reposity for my PhD thesis
MIT License
0 stars 1 forks source link

Literature chapter #163

Closed Nikoleta-v3 closed 4 years ago

Nikoleta-v3 commented 4 years ago

This is a draft of the literature review chapter.

Closes #109

To address before merging:

drvinceknight commented 4 years ago

Why is https://github.com/Nikoleta-v3/Thesis/pull/163/files?file-filters%5B%5D=.pdf&file-filters%5B%5D=.png&short_path=687f062#diff-687f06273847810bdd4879a5aad564a3 a png file?

Nikoleta-v3 commented 4 years ago

It wasn't meant to be one. 👍

drvinceknight commented 4 years ago

It wasn't meant to be one. 👍

:+1:

Also I wonder if https://github.com/Nikoleta-v3/Thesis/blob/13e0a411addd733ca5280e17dcf8ed138998e5d2/src/chapters/02/main.ipynb (the notebook) could perhaps be cleaned a bit more: just add a few sentences here and there so that theoretically someone could be reading your chapter and looking at the notebook at the same time? (I realise this is unlikely)

Nikoleta-v3 commented 4 years ago

Not a bad idea. I will probably just add a few sentences regarding what the fingerprints are and where there are in the main tex

drvinceknight commented 4 years ago

It wasn't meant to be one.

The other fingerprint is a png as well. :+1:

Nikoleta-v3 commented 4 years ago

I had to force push because I rebased to master 13d64f0

drvinceknight commented 4 years ago

I had to force push because I rebased to master 13d64f0

Cool.

To address before merging:

  • [x] #160
  • [x] #159
  • [x] #162 ?

Let me know when you want me to take another look :+1:

Nikoleta-v3 commented 4 years ago

What are you thoughts on #162? and can you address my comment https://github.com/Nikoleta-v3/Thesis/pull/163#discussion_r386623384

drvinceknight commented 4 years ago

What are you thoughts on #162?

Not a bad idea, worth including the other ones?

Nikoleta-v3 commented 4 years ago

I am not sure about the other ones. The only reason I am considering LookUp is because it can include an example of "training". That the action after a given combination changes.

drvinceknight commented 4 years ago

I am not sure about the other ones. The only reason I am considering LookUp is because it can include an example of "training". That the action after a given combination changes.

You do talk about neural networks as well...

Nikoleta-v3 commented 4 years ago

Yes I do. I am just thinking that it will be just a beautiful image to accompany the text. In the text when explaining lookup tables I also introduce the idea of training. So having the diagram helps/adds value to the text.

I am not disagreeing with your comment just trying to get it right

drvinceknight commented 4 years ago

Yes I do. I am just thinking that it will be just a beautiful image to accompany the text. In the text when explaining lookup tables I also introduce the idea of training. So having the diagram helps/adds value to the text.

I am not disagreeing with your comment just trying to get it right

I don't feel strongly either way @Nikoleta-v3 :) Add the one figure and we might feel later on that it's worth adding a second (or more). :+1: