search

Nikoleta-v3 / meta-analysis-of-prisoners-dilemma-tournaments

A repo to generate axelrod tournaments
MIT License
0 stars 1 forks source link

Minor consistency edits #30

Closed Nikoleta-v3 closed 4 years ago

Nikoleta-v3 commented 4 years ago

This addresses the TODOs by @drvinceknight. Except citing the repository, I will do this after the prs have been merged and the tests are passing.

It also includes some minor copy edits, some additions to several discussions and the re write of the discussion section.

The commits address a single thing.

Nikoleta-v3 commented 4 years ago

@drvinceknight and @marcharper this is now ready to review 👍

Nikoleta-v3 commented 4 years ago

I am going to ahead and commit @drvinceknight suggestions because they are correcting typos.

marcharper commented 4 years ago

Overall it looks good to me. I left a bunch of mostly nitpicky comments. Last thing I want to check is the DC to C ratios (I should be able to do so now with Nik's updates to the data processing scripts).

Nikoleta-v3 commented 4 years ago

Thank you @marcharper I will go over and address your comments. Let me know if you are having any issues with the data 👍