search

NilaySheth / android-protips-location

Automatically exported from code.google.com/p/android-protips-location
0 stars 0 forks source link

FroyoLocationUpdateRequester does not contain an implementation for requestLocationUpdates() #10

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The FroyoLocationUpdateRequester does not contain an implementation for the 
requestLocationUpdates() method defined in the abstract base class 
LocationUpdateRequester.

Suggested fix:  pull the implementation for requestLocationUpdates() up from 
the child class "GingerbreadLocationUpdateRequester".

Additional suggestion:  Add a "removeUpdates(PendingIntent p)" to the class 
hierarchy, so that the requester (code that actually holds the PendingIntent) 
can signal to the location manager that it's no longer interested in location 
updates.  See attached files for implementation.  Implement similar for 
LegacyLocationUpdateRequester.

Original issue reported on code.google.com by daniel.m...@gmail.com on 28 Oct 2011 at 6:44

Attachments:

GoogleCodeExporter commented 9 years ago 
I disagree. The implementation in GingerbreadLocationUpdateRequester invokes a 
method that does not exist in Froyo.

I think the implementation for 
FroyoLocationUpdateRequester.requestLocationUpdates(long, long, Criteria, 
PendingIntent) should come from LegacyLastLocationFinder.

Original comment by cow...@bbs.darktech.org on 7 May 2012 at 2:07