Closed rquadling closed 9 years ago
Just a small tip. To reproduce the issue, I had to change the user.language:
java -Duser.country=gb -jar ...
What do you think if we rename _messages_enUS.properties to _messagesen.properties? Or someone has to translate resources from US to British :-)
Just copy the current US to GB. There isn't anything I would say/write differently.
I have checked the US resource bundle, and haven't found words that are specific for GB. Probably instead of duplicating resources, maybe it would make sense to "generalize" some of them.
If that's possible. I'm not a Java developer, so I don't know how to abstract that. But I feel generalizing them would be overkill. Unless the intent is to support that for other shared languages (Spanish, Portuguese, etc.) But being only an English speaker, I'm not sure how wide spread such generalisation would be to warrant the additional code.
@rquadling, I have renamed the resource file for English only, because I didn't find strings that could be different in US and GB. The result is in my branch: Fix/Issue31. If you have time, could you please verify whether the warning disappears or not?
I do not suggest to do this for Spanish and/or Portuguese (or other languages), because they might have significant difference. To be honest, we have a pt_BR resource only :)
@Nilhcem, I apologize for bothering you, could you please take a look at this issue as well? Was my proposal acceptable, or you have a better one?
@Vest Sorry, I'm only a user, not a java dev.
Ok then, I thought you've build FakeSMTP before using it. No worries.
@rquadling, @Vest, Thanks, I finally removed the i18n country specifier for every i18n bundles to keep only the language, Changes will be included when the next version (2.1) is published
Hi.
When I load FakeSMTP via ...
`java -jar fakeSMTP-2.0.jar -a 127.0.0.1 -p 25 -s -b -o D:\SMTP`` (yes I'm on Windows).
I get ...
With regard to the locale messages, is there anything important to worry about?
If not, then just close this issue.
Regards,
Richard Quadling.