Nilhcem / FakeSMTP

Dummy SMTP server with GUI for testing emails in applications easily.
http://nilhcem.github.com/FakeSMTP/
Other
990 stars 319 forks source link

Implemented the feature #32 #36

Closed Vest closed 9 years ago

Vest commented 9 years ago

Hello @Nilhcem,

I have added the feature being requested in #32. Could you please review my changes and give me any feedback regarding them?

Kind regards, Vest

Nilhcem commented 9 years ago

Perfect, thanks!

Vest commented 9 years ago

Thanks for the merge. Was everything fine with the code?

Nilhcem commented 9 years ago

I could not do it better,

I wanted to see how the i18n behaves when there's no translation key specified for a given language (the startsrv.err.invalidHost added key) (e.g. if it uses english by default) and finally no, the error message is empty, so I added the translations for the other languages to make sure it works well