Update for bevy 0.6 - Githubissues

rparrett commented 2 years ago

I haven't looked at this in a little while, but I think it was in decent shape. Feel free to edit / squash. Or if you'd like me to squash it, let me know.

Based heavily on the mesh2d_manual example.

Unfortunately, support for 2d meshes in the UI pipeline didn't make it to Bevy 0.6, so that feature was removed.

rparrett commented 2 years ago

So a couple notes:

This adds a new Shape marker component that's needed in queue_shape because Path is (purposely) not extracted in extract_shape. This should probably be made usable by users and perhaps included in the prelude?
Speaking of that, it seems like we are exporting lyon's Path, but not our wrapper?
There are a number of things failing on pedantic clippy lints that seem like totally normal bevy code, e.g. I'm guessing the thing to do here is deny the lint, but should I do that on a function by function basis, globally, or in mod.rs?

warning: this argument is passed by value, but not consumed in the function body
   --> src/render/mod.rs:186:21
    |
186 |     shape_pipeline: Res<ShapePipeline>,
    |                     ^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&Res<ShapePipeline>`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value

Nilirad commented 2 years ago

Thanks!

I would wait to add stuff into the prelude. Those items are already public, if someone really needs them, they can still use them.

Nilirad / bevy_prototype_lyon

Update for bevy 0.6 #134