search

NilsEnevoldsen / ScryfallLinks

MediaWiki extension that creates Scryfall links from Magic: The Gathering card names
MIT License
7 stars 3 forks source link

Sometimes popups don't appear #27

Closed NilsEnevoldsen closed 6 years ago

NilsEnevoldsen commented 6 years ago

I don't have a replicable test case, but sometimes popups don't appear. Nothing amiss appears in the console. When I reload the page, or ?debug=true, they start working. If this happens to anybody else, that'd be good to know.

Maybe I should put some status messages in the console to diagnose this.

NilsEnevoldsen commented 6 years ago

I think sometimes the javascript is getting loaded before the link elements exist. When the popups don't work, I notice that the appended js--card-popup div comes very high up in the body, above the global wrapper. Then if I rerun the code that creates the Tippy object in the page console, the links start working again. So I think I need to delay this script until the global wrapper loads.