search

NilsHolthey / capstone-project

capstone-project-smoky.vercel.app
0 stars 0 forks source link

Doing it list #13

Closed NilsHolthey closed 2 years ago

NilsHolthey commented 2 years ago

with this PR I added the DoingIT list. Routing will be done with the implementation of the navbar(#12 ).

https://github.com/NilsHolthey/capstone-project/issues/10

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
capstone-project ✅ Ready (Inspect) Visit Preview May 18, 2022 at 9:11AM (UTC)
NilsHolthey commented 2 years ago

Hi, thank you for your review. I changed everything except for the < p > . I don't need it for now. But later I will render more than just the the title inside of the list element. That is why I will leave it like it is.

PReichetanz commented 2 years ago

Hi, thank you for your review. I changed everything except for the < p > . I don't need it for now. But later I will render more than just the the title inside of the list element. That is why I will leave it like it is.

Well, I see your point, but according to the Agile workflow, we are not developing for some state in the future, but for now. And right now, you don't need the p element, so delete it. You never know whether you will have time or money to implement these things (I know that this is nitpicking within our sprints, but you might get sick for the next three weeks (I hope you will not!); additionally, I think you will encounter a similar situation in your future job).

Besides, if you want to add more than just the text to you list item, you may want to build a component for all this content anyway - and it is better to build this component from scratch than to add stuff since then you are going to build it the way you need it from the very beginning.

NilsHolthey commented 2 years ago

change it

NilsHolthey commented 2 years ago

Thank You!