search

NiltonVolpato / python-progressbar

Text progress bar library for Python
Other
412 stars 105 forks source link

Fix Percentage and SimpleProgress when maxval is UnknownLength #62

Closed mkillianey closed 5 years ago

mkillianey commented 6 years ago

Also fixed Percentage and SimpleProgress and added an example to see the behavior of widgets that change when maxval is UnknownLength.

mkillianey commented 6 years ago

@niltonvolpato – It looks like the top commit on master right now (PR #48) broke the library, at the very least because it mixed tabs/spaces and also because (IIUC) it created an import circularity. This makes it parsable/usable again (and adds an example to hopefully make it easier to verify that it does what it says).

mkillianey commented 5 years ago

Looks like the indenting and circularity got fixed, but two of the widgets still seem to be broken when maxval is UnknownLength. Changed this pull request to be fixes to those widgets (and add an example to exercises that functionality).

NiltonVolpato commented 5 years ago

Merged. Thanks!