search

NimaSoroush / differencify

Differencify is a library for visual regression testing
MIT License
634 stars 46 forks source link

Add support for accessing detailed test info via toMatchSnapshot callback #83

Closed EranSch closed 6 years ago

EranSch commented 6 years ago

Implements the proposed change agreed upon in #82 along with updates to relevant unit/integration tests and API.md.

@NimaSoroush I think this proposal should be fairly self-explanetory based on our previous discussion but please let me know if you have any questions or would like to see any revisions made before moving forward.

NimaSoroush commented 6 years ago

Hi @Swingline0 , PR looks great. Just added a small comment. You probably need to bump up version in package.json and add a changelog too.

EranSch commented 6 years ago

@NimaSoroush I added the argument description via 491044f. Let me know if it reads correct from a technical perspective or needs revision.

Regarding the version bump, as this is affecting function arguments, do you wish to bump the minor?

NimaSoroush commented 6 years ago

Thanks @Swingline0, Looks great.

Yeah, a minor should be fine

EranSch commented 6 years ago

👍 If it's all the same to you, I'll bump the version and update the changelog once this and #84 are merged.

NimaSoroush commented 6 years ago

Great. I'll merge then