search

NimaSoroush / differencify

Differencify is a library for visual regression testing
MIT License
634 stars 46 forks source link

Build artifacts in 1.4.0 #88

Closed EranSch closed 6 years ago

EranSch commented 6 years ago

@NimaSoroush It appears as though the 1.4.0 package doesn't have the latest build artifacts. Is it possible that it was published without npm run build occurring before hand?

Notice the differing function signatures between my build (left) and the tarball retrieved from NPM (right)

image

If this was a publishing mistake and not something on my end, I would recommend configuring a prepare NPM script such as:

  "prepare": "npm run build"

This will run before publishing as well as after an install from Github, it ensures that no matter how the package is pulled into a project it should have freshly built artifacts.

NimaSoroush commented 6 years ago

Ahh, my bad. That was a publish without build. I'll fix it just now. a prepare command makes sense

EranSch commented 6 years ago

Merged #89, going to close those. Thanks for the always speedy response, @NimaSoroush!

NimaSoroush commented 6 years ago

Thanks for raising this. Fixed! https://www.npmjs.com/package/differencify

EranSch commented 6 years ago

Can confirm, 1.4.1 works beautifully. Thanks!