search

Nimastic / pe

0 stars 0 forks source link

Invalid Search Command Lists Clients with Previously Invalid Birthdates #9

Open Nimastic opened 4 days ago

Nimastic commented 4 days ago

Earlier on, when adding clients with invalid birthdates (E.g. 1990-02-31), the system will handle and set the clients' birthday to the closest valid birthdate.

However, when searching for clients with invalid birthdates, the search command does not handle it nor throw errors, and instead, lists all clients with previously invalid birthdates with the accurate birthdates.

While not entirely wrong, I believe the invalid birthdates are saved and therefore showing users with previously incorrect birthdates.

image.png

nus-pe-script commented 1 day ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Hi, thanks for pointing that out. The team acknowledges this issue and has mentioned that we plan to fix this search function issue in the planned enhancement in the screenshot attached (point 5). As such, the team will be marking this bug as "rejected". Do let us know your thoughts. Thanks! :)

Screenshot 2024-11-18 at 1.36.55 PM.png Screenshot 2024-11-18 at 1.36.55 PM

Screenshot 2024-11-18 at 1.40.23 PM.pngScreenshot 2024-11-18 at 1.40.23 PM

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]