Nimdy / Dedicated_Valheim_Server_Script

Valheim Server Manager . Supports: ValheimPlus, Bepinex, Multi-world, Multi-Lang, Update, Backup, Restore and more: Built for Linux
GNU Affero General Public License v3.0
697 stars 120 forks source link

[BUG] Incorrect server naming if there is a space #197

Closed ShikyoKira closed 3 years ago

ShikyoKira commented 3 years ago

If the server name has a space for example "The server name", only "The" will be shown in client PC

Steps to reproduce the behavior:

  1. Have a server name with space
  2. Start the server with mods enabled
  3. Refresh client server list
Nimdy commented 3 years ago

strange.... Capture

seems to be just correct...

Nimdy commented 3 years ago

Capture from the advance menu now

Nimdy commented 3 years ago

i need help reproducing this? I am unable

Nimdy commented 3 years ago

i believe I did more than just fix this.

Rebuild your config file by enabling public... even if its already enabled.

stop your valheim server and then start it again

You server should also now show up in the public listing as well

djmarley commented 3 years ago

I had the same issue, but it only happened when running with mods enabled. I ended up adding quotes around ${server_name} on the last line in start_server_bepinex.sh and it seemed to fix the problem.

Nimdy commented 3 years ago

i am confused again...

"${VALHEIM_PLUS_PATH}/${executable_name}" -name "${server_name}" -password "${server_password}" -port "${server_port}" -world "${server_world}" -public "${server_public}"

it already has qoutes....

Nimdy commented 3 years ago

btw I have tested about 50 plus installed today... The Public listings are still hit or miss

I would have one show up and restart the service... never popped up again.... steamclient.so is solid too... These are the same issues ARK still has today... so who knows... I will keep trying though

djmarley commented 3 years ago

Hopefully this helps! Here's the last line I edited with the added quotes around ${server_name}. My full server name now shows, even after restarts.

"${PWD}/${executable_name}" -name "${server_name}" -password ${server_password} -port ${server_port} -world ${server_world} -public ${server_public}

Nimdy commented 3 years ago

thanks what version of the menu are you running?

Nimdy commented 3 years ago

yeah that was teh last version from v+

They released a emergent patch after and I applied it to the new update.

Nimdy commented 3 years ago

https://github.com/Nimdy/Dedicated_Valheim_Server_Script/search?q=%7BPWD%7D

yeah ${PWD} isnt even found in my repo anymore :(, it was updated... V+ had issues...

Thanks for the help though :)