search

NimmLor / esp8266-fastled-iot-webserver

A universal software for all my LED projects, with many awesome features
https://www.thingiverse.com/surrbradl08/designs
GNU General Public License v3.0
366 stars 94 forks source link

Change udp parsing to use 'read' instead of 'readBytes' #205

Closed CastleSeven closed 2 years ago

CastleSeven commented 2 years ago

Verified the parsing of udp packets when using visualizer patterns was taking ~ 1000ms, resulting in a very low fps when using these particular patterns. Narrowed the timing down to Udp.readBytes(). After being unable to find a solid reference for readBytes or why it might be taking so long to return, I tested with a simple 'read()' call and am now getting normal speeds from the visualizer patterns.

issue #204

CastleSeven commented 2 years ago

@WarDrake it doesn't look like I have permission to assign you to this, but here's the PR for the random UDP fix we discussed yesterday.

WarDrake commented 2 years ago

Thanks @CastleSeven I'm gonna test this later tonight and merge if all good.