Nimrodda / flutter_nsd

A Flutter plugin that enables Network Service Discovery (mDNS) on various platforms via their native APIs.
Apache License 2.0
34 stars 8 forks source link

Fixed repeated duplicate results on Windows #25

Closed jnstahl closed 2 years ago

jnstahl commented 2 years ago

added a simple filter to eliminate duplicate results. Note that occasionally some results still come twice, as e.g. an ipv6 may be resolved later than the ipv4, in which case the results will be sent again with the added information

Nimrodda commented 2 years ago

Thanks for taking care of this so quickly! 👍 Looks good. I'll merge it.

jnstahl commented 2 years ago

Even with this change it remains to be seen if the results match the other platforms 100% - The information that is returned from the windows implementation is strictly what is returned in the MDNS packets; it does not use any other OS resources to fill in missing content. But it works well enough that I have already released 2 apps to production.