search

Nimrodda / flutter_nsd

A Flutter plugin that enables Network Service Discovery (mDNS) on various platforms via their native APIs.
Apache License 2.0
34 stars 8 forks source link

AGP8 compatibility #48

Closed deckerst closed 1 year ago

deckerst commented 1 year ago

Main change is adding namespace for AGP8 compatibility. Rest is upgrades so that the example can compile on a modern setup with recent Flutter/Gradle.

deckerst commented 1 year ago

Also have you verified the the example app works?

Yes. And this fix for AGP8 has been used in many repos already.

Nimrodda commented 1 year ago

checks failed Because flutter_nsd_example depends on cupertino_icons >=1.0.6 which requires SDK version >=2.19.0 <4.0.0, version solving failed.. Let's address that before I merge this.

deckerst commented 1 year ago

Interesting. In my environment I use a recent Dart SDK which requires null safety, so I needed to bump cupertino_icons version to make it build. But your GitHub workflow uses an old Dart SDK (< 2.19.0). That Dart SDK version depends on the Flutter version you specified in env.FLUTTER_VERSION which is setup at the repo level. So my understanding is that you can bump that FLUTTER_VERSION. Otherwise, feel free to reject this PR.

Nimrodda commented 1 year ago

Interesting. In my environment I use a recent Dart SDK which requires null safety, so I needed to bump cupertino_icons version to make it build. But your GitHub workflow uses an old Dart SDK (< 2.19.0). That Dart SDK version depends on the Flutter version you specified in env.FLUTTER_VERSION which is setup at the repo level. So my understanding is that you can bump that FLUTTER_VERSION. Otherwise, feel free to reject this PR.

I use FVM for Flutter versioning. Could you please update it and we see if it fixes the issue?