search

Nimut / testing-framework

TYPO3 testing framework that provides base classes and configuration for PHPUnit tests
GNU General Public License v2.0
52 stars 25 forks source link

Update PHPUnit compatibility #133

Closed IchHabRecht closed 2 years ago

IchHabRecht commented 4 years ago

Raise PHPUnit compatibility to versions 8.x and 9.x

Resolves: #119

dkd-kaehm commented 3 years ago

I rebased your branch and testet it within EXT:solr local and on travis. It was the dependency for my tries on paratest integration.

helhum commented 3 years ago

Here is my branch with rebased commits: https://github.com/helhum/TYPO3-testing-framework/tree/php8

mbrodala commented 3 years ago

@IchHabRecht @helhum how to proceed here? It looks like @helhum already did prepare the necessary updates ...

IchHabRecht commented 3 years ago

The problem should be solved in https://github.com/Nimut/testing-framework/commit/9e4f5df15a9f75277c1704a36dce452d2cec5edc

mbrodala commented 3 years ago

@IchHabRecht Thanks, I've successfully upgraded to PHPUnit 8.5 with this.

However with PHPUnit 9 an issues occurs because the the Text_Template class has been renamed to SebastianBergmann\Template\Template:

Error: Class 'Text_Template' not found
/.../vendor/nimut/testing-framework/src/TestingFramework/TestCase/AbstractFunctionalTestCase.php:473

This has been reported in https://github.com/Nimut/testing-framework/issues/144 already AFAIS.

(There's another one, but this can be migrated locally as mentioned: PHPUnit\Framework\TestCase::prophesize() is deprecated and will be removed in PHPUnit 10. Please use the trait provided by phpspec/prophecy-phpunit.)