search

NinesStack / sidecar

Gossip-based service discovery. Docker native, but supports non-container discovery, too.
MIT License
69 stars 7 forks source link

Enable support for older versions of the Envoy gRPC API #55

Closed mihaitodor closed 4 years ago

mihaitodor commented 4 years ago

Hey @relistan, this should allow us to use the gRPC API with Envoy v1.8.0. I tested it using my DinD setup here.

For the latest Envoy (v1.15.0), it will generate a bunch of deprecation warnings in the logs of Envoy, which can be quite noisy and it looks like they don't have a good way to suppress them (see here. I think it's best to revert this change once we're happy with the upgrade.

This change is needed because typed_config is not implemented in v1.8.0 / v1.9.0. The newer versions have it implemented here.